-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace excel screenshots by embedded file contents #598
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/swcarpentry/r-novice-inflammation/compare/md-outputs..md-outputs-PR-598 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2023-12-02 12:34:39 +0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @Bisaloo. Would it be possible to embed only a few lines? Currently this adds way too much to the length of the document which would likely be problematic from an accessibility standpoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment :)
I'm still unsure of what would be the best way to do this. I went with saving only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks @Bisaloo.
Auto-generated via {sandpaper} Source : 6380440 Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2023-12-14 22:25:25 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : b1dcb95 Branch : main Author : Rohit Goswami <r95g10@gmail.com> Time : 2023-12-14 22:24:13 +0000 Message : Merge pull request #598 from swcarpentry/issue-434-excel-screenshots Replace excel screenshots by embedded file contents
Auto-generated via {sandpaper} Source : a6ea81d Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2023-12-19 00:23:43 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : b1dcb95 Branch : main Author : Rohit Goswami <r95g10@gmail.com> Time : 2023-12-14 22:24:13 +0000 Message : Merge pull request #598 from swcarpentry/issue-434-excel-screenshots Replace excel screenshots by embedded file contents
Auto-generated via {sandpaper} Source : a6ea81d Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2023-12-19 00:23:43 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : b1dcb95 Branch : main Author : Rohit Goswami <r95g10@gmail.com> Time : 2023-12-14 22:24:13 +0000 Message : Merge pull request #598 from swcarpentry/issue-434-excel-screenshots Replace excel screenshots by embedded file contents
Auto-generated via {sandpaper} Source : a6ea81d Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2023-12-19 00:23:43 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : b1dcb95 Branch : main Author : Rohit Goswami <r95g10@gmail.com> Time : 2023-12-14 22:24:13 +0000 Message : Merge pull request #598 from swcarpentry/issue-434-excel-screenshots Replace excel screenshots by embedded file contents
Fix #434.
This will also be hopefully more accessible for visitors using screenreaders since they can now more easily access the full information that was previously summarized in a terse alt text.