Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Code generator doesn't preserve original case for variables #12509

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ShemTovYosef
Copy link

@ShemTovYosef ShemTovYosef commented Dec 22, 2024

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Solves this issue: #12505
Provides support in codegen for Python to preserve original names for variables

Usage example with maven plugin:

<plugin>
                <groupId>io.swagger</groupId>
                <artifactId>swagger-codegen-maven-plugin</artifactId>
                <version>2.4.41</version>
                <executions>
                    <execution>
                        <id>python-swagger-client</id>
                        <goals>
                            <goal>generate</goal>
                        </goals>
                        <configuration>
                            <inputSpec>${basedir}/target/resources/services.yaml</inputSpec>
                            <output>${basedir}/target/generated_sources</output>
                            <templateDirectory>${basedir}/templates</templateDirectory>
                            <generateApiTests>false</generateApiTests>
                            <generateModelTests>false</generateModelTests>
                            <language>python</language>
                            <additionalProperties>
                                <property>case=original</property>
                            </additionalProperties>
                        </configuration>
                    </execution>
                </executions>
            </plugin>

@ShemTovYosef
Copy link
Author

Hi @frantuma can you review please?

@ShemTovYosef
Copy link
Author

Hi @Alexizx00789999
Thank you for approving but it still requires someone with write access, do you know who can help ?

@ShemTovYosef
Copy link
Author

Hi @frantuma @HugoMario can you merge it please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant