Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly highlight sources reassigned inside trace #14811

Merged
merged 6 commits into from
Jan 3, 2025

Conversation

paoloricciuti
Copy link
Member

@paoloricciuti paoloricciuti commented Dec 23, 2024

Alternative to #14801
Closes #14794
Closes #14869

This fixes two bugs: one where the sources reassigned in the trace where not properly highlighted and another where the value logged was not correct (it showed the value of the source after the reassignment).

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Dec 23, 2024

🦋 Changeset detected

Latest commit: 83473d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-14811-svelte.vercel.app/

this is an automated message

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14811

@webJose
Copy link
Contributor

webJose commented Dec 24, 2024

@paoloricciuti hello. I haven't had the time to help out with your request in the other PR, which got closed. I see you opened this new one. Is this new one working on my code? If not, I'll try to check it out today.

@paoloricciuti
Copy link
Member Author

@paoloricciuti hello. I haven't had the time to help out with your request in the other PR, which got closed. I see you opened this new one. Is this new one working on my code? If not, I'll try to check it out today.

It should...maybe if you have some time check out the result to see if it make sense for you too

@trueadm
Copy link
Contributor

trueadm commented Jan 3, 2025

The code looks good to me, can you share a video or screenshots with the before and after too please?

@paoloricciuti
Copy link
Member Author

The code looks good to me, can you share a video or screenshots with the before and after too please?

Sure will do in a bit

@paoloricciuti
Copy link
Member Author

@trueadm here it is

Before

image

After

image

@paoloricciuti paoloricciuti merged commit a91308d into main Jan 3, 2025
11 checks passed
@paoloricciuti paoloricciuti deleted the fix-inspect-trace-highlight branch January 3, 2025 20:40
@github-actions github-actions bot mentioned this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants