Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDA - Fixes and more controls #268

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

GDA - Fixes and more controls #268

wants to merge 17 commits into from

Conversation

ngmachado
Copy link
Collaborator

@ngmachado ngmachado commented Feb 1, 2024 •
edited
Loading

This PR introduces GDA cases fixes.

  • This is still WIP, but we should run it anyway for @elvijsTDL QA and bug hunting.
  • I also introduce a new endpoint called estimate that i find it useful when testing with @d10r and @elvijsTDL
curl -X POST http://localhost:8080/estimate -H "Content-Type: application/json" -d '{"account":"ACCOUNT_ADDRESS", "token":"TOKEN_ADDRESS"}'

@ngmachado ngmachado requested a review from d10r February 1, 2024 20:26
@ngmachado ngmachado self-assigned this Feb 1, 2024
@ngmachado ngmachado marked this pull request as draft February 1, 2024 22:07
d10r
d10r reviewed Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@d10r d10r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get github notifications bugging me to review this PR despite it being a draft. Trying to get rid of those by adding this "review".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d10r d10r d10r left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@ngmachado ngmachado

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngmachado @d10r