Dashboard development sans node #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor ubus and infogather api code into their own files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to discussion in #1.
I moved the ubus and infogather API calls to their own files (see src/actions/ubusAPI.js and src/actions/infogatherAPI.js) and added
npm run build-devthat builds the app in "development" mode (i.e. uses stubbed API calls). This way you can develop the web app without having a node around.There's also a
publish-to-node.shscript that helps you copy your build over to the node if/when you're ready to test the real environment.I updated the README to reflect these changes.