Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding query to fetch x/gov module address #831

Merged
merged 2 commits into from
Oct 18, 2023
Merged

feat: adding query to fetch x/gov module address #831

merged 2 commits into from
Oct 18, 2023

Conversation

spoo-bar
Copy link
Contributor

  • Added helper functions to query a module account information.
  • With x/gov v1 types, the governance module address is likely to be used quite often. chain.GetGovernanceAddress() would be nice to have

@spoo-bar spoo-bar requested a review from a team as a code owner October 18, 2023 10:16
@spoo-bar spoo-bar requested a review from misko9 October 18, 2023 10:16
@Reecepbcups Reecepbcups added the dont_backport Do not backport to any other maintained branch label Oct 18, 2023
@Reecepbcups Reecepbcups merged commit cbabe40 into strangelove-ventures:main Oct 18, 2023
9 checks passed
@Reecepbcups Reecepbcups removed the dont_backport Do not backport to any other maintained branch label Oct 18, 2023
@Reecepbcups
Copy link
Member

@Mergifyio backport v7

@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2023 •
edited
Loading

backport v7

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 18, 2023
@spoo-bar @mergify
feat: adding query to fetch x/gov module address (#831)
63837bf 
* adding query to fetch module address

* adding test

(cherry picked from commit cbabe40)
@mergify mergify bot mentioned this pull request Oct 18, 2023
Merged
Reecepbcups pushed a commit that referenced this pull request Oct 18, 2023
@mergify @spoo-bar
feat: adding query to fetch x/gov module address (#831) (#832)
4e30fc4 
* adding query to fetch module address

* adding test

(cherry picked from commit cbabe40)

Co-authored-by: Spoorthi <9302666+spoo-bar@users.noreply.github.com>
@spoo-bar spoo-bar deleted the spoorthi/adding-gov-module-addr-fetch branch October 19, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reecepbcups Reecepbcups Reecepbcups approved these changes

@misko9 misko9 Awaiting requested review from misko9 misko9 is a code owner automatically assigned from strangelove-ventures/interchaintest-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spoo-bar @Reecepbcups