Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement override flag when creating clients #1237

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

boojamya
Copy link
Contributor

In order to create two different clients on chains you already have configured, you need to use the --override flag in the relayer.

This PR adds the ability to take advantage this --override flag with interchaintest.

Note that this is only implemented for the go relayer.

@boojamya boojamya requested a review from a team as a code owner August 26, 2024 22:01
@boojamya boojamya requested review from misko9 and agouin August 26, 2024 22:01
Copy link

vercel bot commented Aug 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
interchaintest-docs ⬜️ Ignored (Inspect) Visit Preview Aug 26, 2024 10:01pm

@Reecepbcups Reecepbcups enabled auto-merge (squash) August 26, 2024 22:03
@Reecepbcups
Copy link
Member

Reecepbcups commented Aug 26, 2024

If we need to expand this further, I almost feel we should just have an ExtraFlags []string to ensure it can be expanded easily without modification to the CreateClientOptions. Out of scope for this PR

@Reecepbcups Reecepbcups merged commit 8c49a29 into strangelove-ventures:main Aug 26, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants