test(ics): validate consumer transactions execute #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Reecepbcups
changed the title
jtieri
reviewed
May 6, 2024
Reecepbcups
commented
May 7, 2024
| @@ -1044,323 +1034,6 @@ func (c *CosmosChain) Start(testName string, ctx context.Context, additionalGene | |||
| return testutil.WaitForBlocks(ctx, 2, c.getFullNode()) | |||
| } | |||
|
|
|||
| // Bootstraps the provider chain and starts it from genesis | |||
| func (c *CosmosChain) StartProvider(testName string, ctx context.Context, additionalGenesisWallets ...ibc.WalletAmount) error { | |||
There was a problem hiding this comment.
This is all just copy pasted to the new ics.go file. Easier future maintenance since it typically lags major versions
chain/cosmos/ics.go
Outdated
Comment on lines
45
to
46
| require.NoError(t, r.StopRelayer(ctx, eRep)) | ||
| require.NoError(t, r.StartRelayer(ctx, eRep, ibcPath)) |
There was a problem hiding this comment.
I tried with just StartRelayer but it does not work, likely since the relayer is already running in the background. I don't feel a RestartRelayer is needed on the relayer interface for this.
| } | ||
|
|
||
| // Bootstraps the provider chain and starts it from genesis | ||
| func (c *CosmosChain) StartProvider(testName string, ctx context.Context, additionalGenesisWallets ...ibc.WalletAmount) error { |
There was a problem hiding this comment.
everything below is copy paste from other file
Reecepbcups
commented
May 7, 2024
Comment on lines
+204
to
+210
| if len(icsProviderPaths) > 0 { | ||
| logger.Info("ICS provider setup", zap.Any("icsProviderPaths", icsProviderPaths)) | ||
|
|
||
| for ibcPath, chain := range icsProviderPaths { | ||
| if provider, ok := chain.(*cosmos.CosmosChain); ok { | ||
| if err := provider.FinishICSProviderSetup(ctx, relayer, eRep, ibcPath); err != nil { | ||
| log.Fatal("FinishICSProviderSetup", err) |
There was a problem hiding this comment.
local-ic start interchainsecurity, manually tested and executed against a neutron testnet without issue :)
local-ic interact localneutron-1 bin 'tx bank send acc0 neutron1hj5fveer5cjtn4wd6wstzugjfdxzl0xpznmsky 5untrn --keyring-backend=test --node=%RPC% --chain-id=%CHAIN_ID% --yes'
Chains without ICS (base.json) function as expected as well
|
|
mergify bot
pushed a commit
that referenced
this pull request
May 8, 2024
* base WIP * try the prev attempt with new migration * attempting to bring back old + migration, no work * working * reduce complexity * add p->c IBC test (fails due to TRYOPEN) * rm unused * move ICS functions to their own .go * StartRelayer right after build with longer history * touchups * add back `StopRelayer` before `StartRelayer` * refactor: `FinishICSProviderSetup` * multiple ICS version checks (v3.1, 3.3, 4.0) * local-ic: call FinishICSProviderSetup on setup * rm `interchaintest.DefaultBlockDatabaseFilepath` * rm `interchaintest.DefaultBlockDatabaseFilepath` from other test (cherry picked from commit 65cce0c) # Conflicts: # chain/cosmos/cosmos_chain.go # examples/cosmwasm/rust-optimizer/rust_optimizer_test.go # examples/cosmwasm/workspace-optimizer/workspace_optimizer_test.go # examples/ibc/ics_test.go # local-interchain/interchain/start.go
2 tasks
Reecepbcups
added a commit
that referenced
this pull request
May 10, 2024
…#1119) * test(ics): validate consumer transactions execute (#1115) * base WIP * try the prev attempt with new migration * attempting to bring back old + migration, no work * working * reduce complexity * add p->c IBC test (fails due to TRYOPEN) * rm unused * move ICS functions to their own .go * StartRelayer right after build with longer history * touchups * add back `StopRelayer` before `StartRelayer` * refactor: `FinishICSProviderSetup` * multiple ICS version checks (v3.1, 3.3, 4.0) * local-ic: call FinishICSProviderSetup on setup * rm `interchaintest.DefaultBlockDatabaseFilepath` * rm `interchaintest.DefaultBlockDatabaseFilepath` from other test (cherry picked from commit 65cce0c) # Conflicts: # chain/cosmos/cosmos_chain.go # examples/cosmwasm/rust-optimizer/rust_optimizer_test.go # examples/cosmwasm/workspace-optimizer/workspace_optimizer_test.go # examples/ibc/ics_test.go # local-interchain/interchain/start.go * merge in some non backported features * add back in ICS test * fix ICS test --------- Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com> Co-authored-by: Reece Williams <reecepbcups@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #1088 (comment)
TODO