Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TRACKING] Derive defmt::Format #165

Closed
wants to merge 3 commits into from
Closed

[TRACKING] Derive defmt::Format #165

wants to merge 3 commits into from

Conversation

AdinAck
Copy link
Contributor

@AdinAck AdinAck commented Jan 8, 2025

I keep needing to add defmt::Format derives as I work, rather than spam PRs, let's track them in here.

@AdinAck
Copy link
Contributor Author

AdinAck commented Jan 10, 2025

I just realized this needs to go down to the PAC level... lots of HAL structures hold PAC generics.

@burrbull
Copy link
Member

I just realized this needs to go down to the PAC level... lots of HAL structures hold PAC generics.

https://docs.rs/crate/stm32g4-staging/0.19.0/features

@AdinAck
Copy link
Contributor Author

AdinAck commented Jan 10, 2025

Awesome!

Looks like moving over to stm32g4-staging adds a lot of errors unfortunately.

@burrbull
Copy link
Member

Looks like moving over to stm32g4-staging adds a lot of errors unfortunately.

https://github.com/stm32-rs/stm32g4xx-hal/tree/staged-pac

@AdinAck
Copy link
Contributor Author

AdinAck commented Jan 10, 2025

Wow you guys are great. I'll close this PR and move it over to the staging branch.

Thanks!

@AdinAck AdinAck closed this Jan 13, 2025
@AdinAck AdinAck deleted the defmt-format branch January 13, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdinAck @burrbull