More Configurability #31
Conversation
Makes disabling the dawn message clearer and makes sense since a "sendSleepingMessage" option is also provided
Specifies whether the time until dawn is appended to the sleep message, also uses String.format() to template the string, maybe better for memory ??
Steveplays28
added
the
enhancement
|
Hey Ricky, thanks for your PR, it looks really good! |
|
For sure! Was just perusing mods for a server I'm making and thought of a few features ^^ I could work on making a TPS tracker of some sort like I saw in #7 but I can't guarantee when or if that would get done, probably after I get the server up and running |
|
That would be neat! Maybe we could depend on Carpet Core, because I believe it has TPS tracker functionality in its API. |
|
Could you rebase against main? Did some cleanup that I forgot to cherry pick from the 1.20 branch. |
|
Ope- Completely slipped my mind, let me take care of that ye |
Makes disabling the dawn message clearer and makes sense since a "sendSleepingMessage" option is also provided
Specifies whether the time until dawn is appended to the sleep message, also uses String.format() to template the string, maybe better for memory ??
|
I think this should do it? I have no idea how rebasing works but I selected my stuff, if this is not right I will just refork it 💀 |
|
That seems to be fine! I'll merge and release it sometime soon. |
|
Thanks! Will look into your issue sometime next week. |
Co-authored-by: Steveplays28 <djspaargaren@outlook.com> (cherry picked from commit 3420dc9)
Adds two config options:
sendDawnMessage - specifies whether to send the dawn message, makes sense since a "sendSleepingMessage" option is also provided and makes disabling the message more obvious
showTimeUntilDawn - specifies whether the time until dawn should be appended to the sleeping message, made true by default. Allows for greater vanilla parity
Also changed the construction of the sleeping message to use String.format() which would maybe have a tiiiiiiny improvement for memory use lol