fix(ts bindings): handle SAC spec #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemneal
force-pushed
the
fix/SAC-bindings
branch
from
d3b9ee0 to
95ddc45
Compare
chadoh
force-pushed
the
fix/SAC-bindings
branch
from
95ddc45 to
e347870
Compare
1 task
chadoh
force-pushed
the
fix/SAC-bindings
branch
from
e347870 to
16ecdc0
Compare
Wasm files have metadata that isn't currently used by typebindings. However, we were creating a higher level Spec (not just `Vec<ScSpecEntry>`), from the raw bytes of the XDR. Also, add initialization logic in `cmd/crates/soroban-spec-typescript/ts-tests` and a test to show that we can generate typebindings from the native asset. Clean up `ts-tests` logic while here, updating "soroban" references with "stellar".
chadoh
force-pushed
the
fix/SAC-bindings
branch
from
16ecdc0 to
c56f778
Compare
chadoh
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While creating the TS Bindings, we were creating a higher level Spec (not just
Vec<ScSpecEntry>), from the raw bytes of the XDR. This higher-level Spec uses metadata from Wasm files, rather than just the rawVec<ScSpecEntry>stuff, but TS Bindings don't even use that extra metadata. This implementation detail resulted in a bug when generating TS Bindings for Stellar Asset Contracts, which do not have the (unused) extra metadata.This adds a test of generating TS Bindings for SAC, and fixes the bug.
We've also cleaned up
ts-testslogic while here, updating "soroban" references with "stellar".