Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute next state from rust library #25

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

isoosiss7
Copy link
Contributor

Description

Title Clear, single line description of the pull request, written as though it was an order.

Then, following a single blank line, a summary of the change and which issue is fixed, including

  • what is the problem being solved
  • why this is a good approach
  • what are the shortcomings of this approach, if any

It may include

  • background information, such as "Fixes #"
  • benchmark results
  • links to design documents
  • dependencies required for this change

The summary may omit some of these details if this PR fixes a single ticket that includes these details. It is the reviewer's discretion.

Changes [Optional]

Multiple changes are not recommended, so this section should normally be omitted. Unfortunately, they are sometimes unavoidable. If there are multiple logical changes, list them separately.

  1. 'foo' is replaced by 'bar'
  2. 'fizzbuzz' is optimized for gas

How Has This Been Tested? [Optional]

Did you need to run manual tests to verify this change? If so, please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

⚠️ Does this require multiple approvals? [Optional]

Please explain which reason, if any, why this requires more than one approval.

  • Is it security related?
  • Is it a significant process change?
  • Is it a significant change to architectural, design?

Checklist:

Code quality

  • I have written clear commit messages
  • I have performed a self-review of my own code
  • This change does not have an unduly wide scope
  • I have separated logic changes from refactor changes (formatting, renames, etc.)
  • I have commented my code wherever necessary (can be 0)
  • I have added tests that prove my fix is effective or that my feature works, if necessary

Project management

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant