Skip to content

Commit

Permalink
add --fatal_warnings flag to error on warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
AlonLStarkWare committed Dec 2, 2024
1 parent 5aba343 commit 852b78b
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/starknet_p2p_specs_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,21 +43,21 @@ jobs:
run: |
for file in ${{ steps.find-protos.outputs.proto_files }}; do
echo "Compiling $file"
protoc --rust_out=experimental-codegen=enabled,kernel=upb:$(mktemp -d) $file
protoc --fatal_warnings --rust_out=experimental-codegen=enabled,kernel=upb:$(mktemp -d) $file
done
- name: Validate Python compatibility
run: |
for file in ${{ steps.find-protos.outputs.proto_files }}; do
echo "Compiling $file"
protoc --python_out=$(mktemp -d) $file
protoc --fatal_warnings --python_out=$(mktemp -d) $file
done
- name: Validate C++ compatibility
run: |
for file in ${{ steps.find-protos.outputs.proto_files }}; do
echo "Compiling $file"
protoc --cpp_out=$(mktemp -d) $file
protoc --fatal_warnings --cpp_out=$(mktemp -d) $file
done
- name: Validate GO compatibility
Expand All @@ -66,7 +66,7 @@ jobs:
export PATH=$PATH:$(go env GOPATH)/bin
for file in ${{ steps.find-protos.outputs.proto_files }}; do
echo "Compiling $file"
protoc --go_out=$(mktemp -d) --go_opt=paths=source_relative $file
protoc --fatal_warnings --go_out=$(mktemp -d) --go_opt=paths=source_relative $file
done
- name: Success Message
Expand Down

0 comments on commit 852b78b

Please sign in to comment.