Skip to content

Commit

Permalink
clean comments
Browse files Browse the repository at this point in the history
  • Loading branch information
AlonLStarkWare committed Dec 2, 2024
1 parent ce9990e commit 73a0936
Showing 1 changed file with 0 additions and 29 deletions.
29 changes: 0 additions & 29 deletions .github/workflows/starknet_p2p_specs_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ jobs:
protoc --rust_out=experimental-codegen=enabled,kernel=upb:$(mktemp -d) $file
done
# protoc --rust_out=experimental-codegen=enabled,kernel=upb:$(mktemp -d) ${{ steps.find-protos.outputs.proto_files }}

- name: Validate Python compatibility
run: |
for file in ${{ steps.find-protos.outputs.proto_files }}; do
Expand All @@ -62,9 +60,6 @@ jobs:
echo "Compiling $file"
protoc --cpp_out=$(mktemp -d) $file
done
# protoc --cpp_out=$(mktemp -d) *.proto
# protoc --cpp_out=$(mktemp -d) ./p2p/proto/*.proto
# protoc --cpp_out=$(mktemp -d) ./p2p/proto/**/*.proto
- name: Validate GO compatibility
run: |
Expand All @@ -75,29 +70,5 @@ jobs:
protoc --go_out=$(mktemp -d) --go_opt=paths=source_relative $file
done
# protoc --go_out=$(mktemp -d) --go_opt=paths=source_relative *.proto
# protoc --go_out=$(mktemp -d) --go_opt=paths=source_relative ./p2p/proto/*.proto
# protoc --go_out=$(mktemp -d) --go_opt=paths=source_relative ./p2p/proto/**/*.proto

# - name: go env GOPATH
# run: go env GOPATH

# - name: export GOPATH
# run: export PATH=$PATH:$(go env GOPATH)/bin

# - name: echo PATH
# run: echo $PATH

# - name: check protoc-gen-go installation dir
# run: ls $(go env GOPATH)/bin/protoc-gen-go

# - name: which protoc-gen-go
# run: which protoc-gen-go

# - name: Validate .proto files for Go compatibility
# run: |
# protoc --go_out=$(mktemp -d) ./p2p/proto/*.proto
# protoc --go_out=$(mktemp -d) ./p2p/proto/**/*.proto

- name: Success Message
run: echo "All proto compilations passed!"

0 comments on commit 73a0936

Please sign in to comment.