chore: Apply Clippy lint collection_is_never_used
#5654
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apply Clippy lint
collection_is_never_used
. This found a lot of collections, mostly in test code, that were created but never read. These fell into a few different categories:#[allow(clippy::collection_is_never_read)]
Note that
collection_is_never_used
is a "Nursery" lint, meaning it's not considered stable/accurate. It's not in the default set of lints Clippy runs, but still useful for finding unused code