-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web): Retrieve dependent pipelines correctly #1459
fix(web): Retrieve dependent pipelines correctly #1459
Conversation
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
ac0776a
to
2187037
Compare
...eb/src/main/java/com/netflix/spinnaker/front50/controllers/V2PipelineTemplateController.java
Outdated
Show resolved
Hide resolved
Can you add some automated tests that demonstrate the bug? I'd also like to see a more specific commit message that mentions what was broken. Thanks. |
4a7e924
to
9c9630b
Compare
@dbyron-sf I have added the tests. And reworded the commit message. Please take a look. |
dependentPipelines API
Here it is: @dbyron-sf : 1402d7b#diff-f2c1cc675d8e520ff0541b397bd0d390483bcf197b0576fe2b5976a8db2de02a |
Issue Summary
This fixes the bug regarding
/v2/pipelineTemplates/<pipeline-template-id>/dependentPipelines
API.Original Issue: spinnaker/spinnaker#6472
Environment
Spinnaker:
1.33.0+
Front50:
us-docker.pkg.dev/spinnaker-community/docker/front50:2.31.0
Description
Given a
templateId
, thegetDependentConfigs
method called bylistDependentPipelines
method, was returningnull
for pipeline configuration, causing the entire API to return[]
even if a specific pipeline template had dependent pipelines.. This seems to be because of 👇 change.This 👆 I believe is meant for
v1
templates. But forv2
templates I believe it has to be 👇 :Here are the swagger-ui screenshots showing before and after the fix 👇
Here are the cURL responses showing before and after the fix 👇
Before
After