Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make project descriptions more beginner friendly #272

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

michelleN
Copy link

No description provided.

@@ -5,7 +5,8 @@ title: SpinKube
{{< blocks/cover title="Hyper-efficient serverless on Kubernetes, powered by WebAssembly."
image_anchor="top" height="full" >}} <a class="btn btn-lg btn-primary me-3 mb-4" href="/docs"> Get
Started <i class="fas fa-arrow-alt-circle-right ms-2"></i> </a>
<p class="lead mt-5">SpinKube is an open source project that streamlines developing, deploying and operating WebAssembly workloads in Kubernetes - resulting in delivering smaller, more portable applications and incredible compute performance benefits.</p>
<p class="lead mt-5">SpinKube is an open source, Kubernetes native project that streamlines developing,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Option to use the word stack if folks like that better.

Suggested change
<p class="lead mt-5">SpinKube is an open source, Kubernetes native project that streamlines developing,
<p class="lead mt-5">SpinKube is an open source, Kubernetes native project stack that streamlines developing,

@michelleN michelleN marked this pull request as ready for review January 8, 2025 23:31
App Custom Resource Definitions (CRDs). Spin Operator watches SpinApp Custom Resources e.g. Spin app
image, replicas, schedulers and other user-defined values and realizes the desired state in the
Kubernetes cluster. Spin Operator introduces a host of functionality such as resource-based scaling
[**Containerd Shim Spin**](https://github.com/spinkube/containerd-shim-spin) provides a containerd shim implementation for running Spin workloads which is then used as a runtime class within Kubernetes for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove the mention of runwasi

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to re-word and realized I kind of like the runwasi mention there. If a user clicks the link, they'll see the description "Facilitates running Wasm / WASI workloads managed by containerd" and that creates a link in understanding between this project and the WASI implementation for k8s. You're the maintainer though so I'm happy to remove it if you'd prefer that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I think we should remove the runwasi mention is that it's not important for users to know what libraires containerd-shim-spin is using or how the shim is implemented. It's more important to highlight what it is doing - a shim for running Spin workloads managed by Containerd.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed. took another stab at it.

@michelleN michelleN force-pushed the homepage branch 2 times, most recently from b486719 to 29082e4 Compare January 9, 2025 01:21
Signed-off-by: Michelle Dhanani <michelle@fermyon.com>
content/en/_index.md Outdated Show resolved Hide resolved
trigger designed specifically for Spin. It enables seamless integration between Spin and MQTT-based
systems, allowing you to automate workflows and trigger actions based on MQTT messages.
[**Spin kube plugin**](https://github.com/spinkube/spin-plugin-kube) is a plugin for the [Spin](https://developer.fermyon.com/spin/v3/index) CLI
thats aim to ease the experience for scaffolding, deploying and inspecting Spin workloads in Kubernetes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
thats aim to ease the experience for scaffolding, deploying and inspecting Spin workloads in Kubernetes.
thats aims to ease the experience of scaffolding and inspecting SpinApp resources in Kubernetes.

[**Spin kube plugin**](https://github.com/spinkube/spin-plugin-kube) is a plugin for the [Spin](https://developer.fermyon.com/spin/v3/index) CLI
thats aim to ease the experience for scaffolding, deploying and inspecting Spin workloads in Kubernetes.

[**Spin Trigger MQTT**](https://github.com/spinkube/spin-trigger-mqtt/) trigger enables seamless integration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally find it confusing to list this trigger since there are more triggers than this one that the shim supports. Yes, this trigger lives in the SK org but i dont think we need to document it here

Co-authored-by: Kate Goldenring <kate.goldenring@gmail.com>
Signed-off-by: Michelle Dhanani <michelle@fermyon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants