Fix: Revert notification changes #3763
Merged
+197
−239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Mikehrn
commented
Jan 3, 2025
•
Mikehrn
commented
- Revert back to old notification system of only triggering one notification at the time
- Add option to hide toasts in compostables, and handle them in the parent in the case of server invites
Mikehrn
commented
Jan 6, 2025
| }) | ||
|
|
||
| isOpen.value = false | ||
| } catch { |
There was a problem hiding this comment.
The change of any of them failing is slim, main cause probably network errors, as validation is already done, but this adds at least some basic error handling in the case this happens
fabis94
requested changes
Jan 6, 2025
|
|
||
| /** | ||
| * Persisting toast state between reqs and between CSR & SSR loads so that we can trigger | ||
| * toasts anywhere and anytime | ||
| */ | ||
| const useGlobalToastState = () => | ||
| useSynchronizedCookie<Optional<ToastNotification[]>>('global-toast-state') | ||
| useSynchronizedCookie<Optional<ToastNotification>>('global-toast-state') |
There was a problem hiding this comment.
i'm wondering what will happen when the page loads in for someone who already has this cookie set with an array of toast notifications, hopefully the code doesn't break (expects a single object, finds an array).
its probably fine, but we should probably validate this assumption locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.