-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(users): bulk lookup users by email #3720
base: main
Are you sure you want to change the base?
Conversation
Can you remind me what this does; do they need to be logged in to use this? Is there a limit on the number of emails which can be passed in? (I see there's a limit of 100 on the results) What is to stop someone dumping in a list of known or guessed email addresses to app.speckle.systems and using that to confirm whether they are users or not? With the status quo of a single look up, they might hit up against our (generous) rate limits (as a fairly weak source of friction against abuse), but does this make it easier to abuse the system? Do we need some sort of lookup limit or rate limit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like a clearer description in the PR of the security/confidentiality implications before we merge.
The PR is parity with existing data egress if you know/guess a user's email. (You must be signed in/have a token.) The ability to do this in bulk does speed things up, in theory. I've lowered the limit to 20 instead of 100 (cc @Mikehrn it sounded like this would be plenty for invite use cases?) If we want to add additional rate limiting I think that can happen in a follow-up so we unblock Mike |
Nice :) Yeah 20 is totally fine, I will limit it 20 as well in the FE, multiple invites at one are are not super common, and if people invite multiple people it's usually 2-3 max |
Description & motivation
Changes:
usersByEmail
query modeled afterusers
querylookupUsersBaseQuery