Possible TTS fix 2 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Жди ревью от Морти. |
|
@Morb0 плиз ревью. |
Morb0
reviewed
Nov 25, 2024
Comment on lines
+45
to
+49
| if (!_contentRootAdded) | ||
| { | ||
| _contentRootAdded = true; | ||
| _res.AddRoot(Prefix, _contentRoot); | ||
| } |
There was a problem hiding this comment.
В теории можно использовать .GetContentRoots() чтоб проверить есть ли уже рут, но да ладно
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание PR
Вторая попытка починить TTS, который ломается после переподключения.
Технические детали
Видимо, новый экземпляр правильно создавался. Но, видимо, не создаётся новый экземпляр
ResourceManager. То есть добавлялся ContentRoot по указанному пути, его нормально использовали, а когда появлялся новыйContentRoot, то он путь не перезаписывал, а баговался. Сейчас мы создаём одинContentRoot, не дизпозаем его и добавляем только один раз.Список изменений
🆑