Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 가장 최근 활동 파트 default 설정 구현 #1089

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Conversation

seojisoosoo
Copy link
Member

🤫 쉿, 나한테만 말해줘요. 이슈넘버

🧐 어떤 것을 변경했어요~?

  • 카테고리 파트 선택 시, 최근 활동 파트가 default로 오도록 구현했어요.

🤔 그렇다면, 어떻게 구현했어요~?

  • 기존에 만들어져있던 useGetMemberProfileOfMe() 훅을 가져다 썼습니다!

❤️‍🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.

📸 스크린샷, 없으면 이것 참,, 섭섭한데요?

@seojisoosoo seojisoosoo self-assigned this Nov 19, 2023
@github-actions github-actions bot requested a review from juno7803 November 19, 2023 14:48
Copy link

github-actions bot commented Nov 19, 2023

✨✨ 스토리북으로 확인하기 ✨✨

Copy link

github-actions bot commented Nov 19, 2023

🚀 프리뷰 배포 확인하기 🚀

https://54121cc0.sopt-internal-dev.pages.dev

Copy link
Member

@NamJwong NamJwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM💟

Comment on lines 52 to 53
const partCategory =
parentCategory && parentCategory.children.find((category) => category.name === sortedSoptActivities[0]?.part);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const partCategory =
parentCategory && parentCategory.children.find((category) => category.name === sortedSoptActivities[0]?.part);
const partCategory =
parentCategory?.children.find((category) => category.name === sortedSoptActivities[0]?.part);

p5;
별 거 아니지만 이렇게 쓰면 더 간단할 것 같아요!

@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 19, 2023
@Tekiter Tekiter added this pull request to the merge queue Nov 20, 2023
Merged via the queue into main with commit a8df532 Nov 20, 2023
4 checks passed
@Tekiter Tekiter deleted the feat/#1083 branch November 20, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: 최근 활동 파트 정보 불러오기
3 participants