-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT/#16] 회원가입 API 구현 #30
Merged
Merged
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
448e280
[FEAT] Sign Up API 정의
yummygyudon 6e7f2a3
[FEAT] Sign Up API 구현
yummygyudon 7c8df06
[MODIFY] Body 데이터 필드 명 수정 (`code` -> `token`)
yummygyudon 5c75ab9
[FEAT] OkHttp Request 중복 생성 코드 방지를 위한 RequestUtil 객체 구현
yummygyudon 7803ac8
[FIX] 관심사에 따라 Http Failure Code 재정의 및 신규 Auth Error Code 추가
yummygyudon d48dce6
[FEAT] OAuth Platform(Apple / Google) 관련 상수 추가
yummygyudon 3af3467
[FIX] 통신 <-> 인증 관심사 재분리 및 각 플랫폼별 ID Token 토큰 검증 기능 추가 구현
yummygyudon 755de14
[FEAT] OAuth Identifier 값 조회 기능 정의 및 구현
yummygyudon 70a5e86
[FEAT] SignUp Service 구현
yummygyudon bded4f1
[MODIFY] UserRegisterInfo Email 필드 누락 추가
yummygyudon 3f58c31
[FEAT] UserRegisterInfo 삭제 구현
yummygyudon 4fe039e
[FEAT] User 생성 및 저장 구현
yummygyudon 6699c60
[CHORE] 오타 수정 및 미사용 변수 선언 제거
yummygyudon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
src/main/java/sopt/makers/authentication/usecase/auth/port/in/SignUpUsecase.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
package sopt.makers.authentication.usecase.auth.port.in; | ||
|
||
import sopt.makers.authentication.domain.auth.AuthPlatform; | ||
|
||
public interface SignUpUsecase { | ||
|
||
void signUp(SignUpCommand command); | ||
|
||
record SignUpCommand(String name, String phone, String authCode, AuthPlatform authPlatform) {} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3
오 이 부분 signUp이 직관적이긴 한데, 행위를 뜻하는 것 같아서 signUpRequest 정도로 바꾸는건 어떠신가요 ?!