Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Op2d->add_const collapse substitution #878

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Add Op2d->add_const collapse substitution #878

merged 3 commits into from
Dec 5, 2023

Conversation

elad-c
Copy link
Collaborator

@elad-c elad-c commented Dec 4, 2023

Pull Request Description:

Add a substitution for collapsing Op2d->add-const into the Op2d node
Op2d: Conv2D, DW-Conv2D, Conv2DTranspose or Dense

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@elad-c elad-c merged commit 12b92f0 into main Dec 5, 2023
24 checks passed
@elad-c elad-c deleted the op2d_add_const_substitution branch December 5, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladc-git eladc-git eladc-git approved these changes

@reuvenperetz reuvenperetz reuvenperetz approved these changes

Assignees
No one assigned
Labels
auto:core auto:tests keras pr: minor feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elad-c @reuvenperetz @eladc-git