Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TensorboardWriter function from core runner #876

Merged
merged 9 commits into from
Dec 3, 2023

Conversation

ofirgo
Copy link
Collaborator

@ofirgo ofirgo commented Nov 30, 2023

Pull Request Description:

This is just a cosmetic change that removes the function for initiating a tensorboard writer object from the core_runner.py file to the tensorboard writer file.
Also, removing some unnecessary imports.
No functionality changes due to this changeset.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

Ofir Gordon added 7 commits November 28, 2023 17:21
…ernal "quantization prep runner": graph analyzing, statistic collection, network editor, qparam calculation, snc and stat correction.

In addition, minor documentation fixes to the graph preparation runner and removed duplicated functions.
@ofirgo ofirgo requested a review from eladc-git December 3, 2023 07:00
@ofirgo ofirgo merged commit 753debd into sony:main Dec 3, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants