Fix mixed precision LP numerical issue #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… case there are values that are larger than the threshold, to preven numerical issues.
Idan-BenAmi
approved these changes
Oct 29, 2023
| Logger.warning(f"The mixed precision distance metric values indicate a large error in the quantized model." | ||
| f"this can cause numerical issues." | ||
| f"The program will proceed with mixed precision search after scaling the metric values," | ||
| f"which can lead to unstable results.") |
There was a problem hiding this comment.
Wouldn't it be more correct? The high values in the mixed precision distance metric may imply a large error in the quantized model which can cause numerical issues
There was a problem hiding this comment.
It is to inform the user that there might be an issue with the model, not the mixed precision necessarily. Such large distance may indicates that something is wrong with the model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a threshold for mixed precision metric and scaling the metric in case some values are larger than the threshold, to prevent numerical issues.
This is supposed to address a possible issue with the pulp library's default LP solver.