Add DepthwiseConv2D to Conv2D substitution #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
model_compression_toolkit/core/keras/graph_substitutions/substitutions/dwconv_to_conv.py
Outdated
Show resolved
Hide resolved
model_compression_toolkit/core/keras/graph_substitutions/substitutions/dwconv_to_conv.py
Outdated
Show resolved
Hide resolved
reuvenperetz
requested changes
Oct 12, 2023
model_compression_toolkit/core/keras/graph_substitutions/substitutions/dwconv_to_conv.py
Outdated
Show resolved
Hide resolved
model_compression_toolkit/core/keras/graph_substitutions/substitutions/dwconv_to_conv.py
Outdated
Show resolved
Hide resolved
model_compression_toolkit/core/keras/graph_substitutions/substitutions/dwconv_to_conv.py
Outdated
Show resolved
Hide resolved
|
General comment: |
…all difference after substitution only when using 'CPU'
reuvenperetz
approved these changes
Oct 17, 2023
reuvenperetz
pushed a commit
to reuvenperetz/model_optimization
that referenced
this pull request
Oct 22, 2023
This reverts commit 827b177.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Substitution for Keras DepthwiseConv2D which isn't handled correctly once depth_multiplier is not 1. The substitution will replaced it with Conv2D and "groups" parameters equal to number of output channels.