Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming TPC #1321

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Renaming TPC #1321

wants to merge 8 commits into from

Conversation

lior-dikstein
Copy link
Collaborator

Pull Request Description:

Renaming:

  • TargetPlatformModel->TargetPlatformCapabilities
  • TargetPlatformCapabilities->FrameworkQuantizationCapabilities
  • tp_model->tpc
  • tpc->fqc
  • target_platform_capabilities->framework_platform_capabilities
  • OperatorSetConcat->OperatorSetGroup

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@@ -21,10 +21,10 @@


# Supported TP models names:
DEFAULT_TP_MODEL = 'default'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m debating this change... this is a breaking change for any user that tried to use the generate_tpc API with IMX500_TP_MODEL
Not sure that we want to break every potential user with this, and we can wait with this to the extraction of the IMX500 TPCs to the external repo.

@@ -14,9 +14,9 @@
# ==============================================================================

from model_compression_toolkit.target_platform_capabilities.target_platform.targetplatform2framework.attribute_filter import AttributeFilter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to get rid of the model_compression_toolkit/target_platform_capabilities/target_platform level in the hierarchy, there is no need for it anymore since there is only the /targetplatform2framework/ in it.
Is it too complicated for this huge PR or do you think it would be fine to include this here as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants