-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming TPC #1321
base: main
Are you sure you want to change the base?
Renaming TPC #1321
Conversation
@@ -21,10 +21,10 @@ | |||
|
|||
|
|||
# Supported TP models names: | |||
DEFAULT_TP_MODEL = 'default' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m debating this change... this is a breaking change for any user that tried to use the generate_tpc API with IMX500_TP_MODEL
Not sure that we want to break every potential user with this, and we can wait with this to the extraction of the IMX500 TPCs to the external repo.
@@ -14,9 +14,9 @@ | |||
# ============================================================================== | |||
|
|||
from model_compression_toolkit.target_platform_capabilities.target_platform.targetplatform2framework.attribute_filter import AttributeFilter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to get rid of the model_compression_toolkit/target_platform_capabilities/target_platform level in the hierarchy, there is no need for it anymore since there is only the /targetplatform2framework/ in it.
Is it too complicated for this huge PR or do you think it would be fine to include this here as well?
Pull Request Description:
Renaming:
Checklist before requesting a review: