Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1270

Merged
merged 7 commits into from
Nov 18, 2024
Merged

Update README.md #1270

merged 7 commits into from
Nov 18, 2024

Conversation

ServiAmirPM
Copy link
Collaborator

@ServiAmirPM ServiAmirPM commented Nov 17, 2024

Round 2 of updaing readme.

  • fixed, designed and repositioned "Supported Feature" section
  • Added dividers between features in features section
  • added API column to the quantization methods table
  • added links to relevant notebooks in relevant places
  • made images of tasks (under results) a bit smaller
  • Fixed Headers issue (some headers were in wrong level.)
  • added more capabilities under debug feature - Xquant & network editor (including links to tutorial
  • centered all section titles (makes the page more clean in my opinion)
  • fixed according to review:
    -- - added tutorials to qadvanced quatntization & Quantization parameter search.
    -- - Updated EPTQ paper title and added E. Cohen as contributer
    -- - changed type (on the how to -> on how to)

Pull Request Description:

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

Round 2 of updaing readme.
- fixed, designed and repositioned "Supported Feature" section
- added API column to the quantization methods table
- added links to relevant notebooks in relevant places
-
@ServiAmirPM ServiAmirPM requested a review from ofirgo November 17, 2024 16:38
fixed broken link to features section
Added more debugging capabilities to the Features section (including reference to specific tutorials)
Changed "target-specific optimization" to "target-aware optimization"
Moved all section titles to be centered (make the page less noisy in my opinion - tell me what you think)
Added dividers between features in features section
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
- added tutorials to qadvanced quatntization & Quantization parameter search. 
- Updated EPTQ paper title and added E. Cohen as contributer
- changed type (on the how to -> on how to)
-
@ServiAmirPM ServiAmirPM merged commit c72cd0f into main Nov 18, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants