Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor QuantizationConfigOptions #1088

Merged
merged 5 commits into from
May 29, 2024
Merged

Conversation

elad-c
Copy link
Collaborator

@elad-c elad-c commented May 28, 2024

Pull Request Description:

Refactor QuantizationConfigOptions to enforce 'base_config' to be a different instance from the one in 'quantization_config_list'

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

…ifferent instance from the one in 'quantization_config_list'
@elad-c elad-c requested a review from ofirgo May 29, 2024 08:08
@elad-c elad-c merged commit 53b8e42 into main May 29, 2024
27 checks passed
@elad-c elad-c deleted the fix_quantization_config_options branch May 29, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants