Remove constant multiplication factor from activation hessian computa…

…tion (#870) Co-authored-by: Ofir Gordon <Ofir.Gordon@altair-semi.com>
sony · Nov 28, 2023 · e76110a · e76110a
1 parent c1551a4
commit e76110a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/model_compression_toolkit/core/keras/hessian/activation_trace_hessian_calculator_keras.py b/model_compression_toolkit/core/keras/hessian/activation_trace_hessian_calculator_keras.py
@@ -152,7 +152,7 @@ def compute(self) -> List[float]:
                     # Compute the final approximation for each output index
                     num_node_outputs = len(interest_point_scores[0])
                     for output_idx in range(num_node_outputs):
-                        final_approx_per_output.append(2 * tf.reduce_mean([x[output_idx] for x in interest_point_scores]) / output.shape[-1])
+                        final_approx_per_output.append(tf.reduce_mean([x[output_idx] for x in interest_point_scores]))
 
                     # final_approx_per_output is a list of all approximations (one per output), thus we average them to
                     # get the final score of a node.

diff --git a/...l_compression_toolkit/core/pytorch/hessian/activation_trace_hessian_calculator_pytorch.py b/...l_compression_toolkit/core/pytorch/hessian/activation_trace_hessian_calculator_pytorch.py
@@ -131,8 +131,8 @@ def compute(self) -> List[float]:
                             break
 
                     trace_hv.append(hessian_trace_approx)
-                ipts_hessian_trace_approx.append(2 * torch.mean(torch.stack(trace_hv)) / output.shape[
-                    -1])  # Get averaged Hessian trace approximation
+
+                ipts_hessian_trace_approx.append(torch.mean(torch.stack(trace_hv)))  # Get averaged Hessian trace approximation
 
             # If a node has multiple outputs, it means that multiple approximations were computed
             # (one per output since granularity is per-tensor). In this case we average the approximations.