Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid bash error when CUPROTOCOMPAT is unset #1204

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

sparr
Copy link
Contributor

@sparr sparr commented Dec 26, 2024

% steamtinkerlaunch vortex install
/bin/steamtinkerlaunch: line 4406: [: : integer expression expected

This error occurs when $CUPROTOCOMPAT is unset. The error does not seem to prevent the script from working.

This PR checks whether it's empty before checking its value.

I'm a bit fuzzy on how to update PROGVERS here and would appreciate some guidance if this is to be accepted.

@sonic2kk
Copy link
Owner

This is great, thank you! Sorry for the delay with getting back, holidays and such 😄

About PROGVERS, just bump it to the current day. For example, v14.0.20241228-1 would be perfectly fine :-)

@sparr sparr force-pushed the handle_empty_cuprotocompat branch from af88c5b to 19ca352 Compare December 28, 2024 19:19
@sonic2kk sonic2kk merged commit 89af3c8 into sonic2kk:master Dec 29, 2024
@sonic2kk
Copy link
Owner

Many thanks for your contribution, it is much appreciated! Changelog has also been updated to give credit: https://github.com/sonic2kk/steamtinkerlaunch/wiki/Changelog/_compare/a262ad1ba229bd9b161a38ad136a27059185a4f1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants