Add Ix Cards for Ed25519 Precompile #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gitteri
reviewed
Jan 16, 2025
| cursor += 14; // Size of one Ed25519SignatureOffsets struct | ||
| } | ||
|
|
||
| return { count, offsets }; |
There was a problem hiding this comment.
returned count is not needed/used. You can remove it unless there's another usage you're expecting
gitteri
reviewed
Jan 16, 2025
| } | ||
|
|
||
| // See https://docs.anza.xyz/runtime/programs/#ed25519-program | ||
| function decodeEd25519Instruction(data: Buffer): { count: number; offsets: Ed25519SignatureOffsets[] } { |
There was a problem hiding this comment.
can you add a couple unit tests for this?
gitteri
reviewed
Jan 16, 2025
| @@ -166,6 +168,7 @@ function InstructionCard({ | |||
| const key = `${index}-${childIndex}`; | |||
| const { program: anchorProgram } = useAnchorProgram(ix.programId.toString(), url); | |||
|
|
|||
| console.log('ix', ix); | |||
There was a problem hiding this comment.
please remove the console.log
ngundotra
added a commit
that referenced
this pull request
Jan 17, 2025
This reverts commit eaa9355.
ngundotra
added a commit
that referenced
this pull request
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example: https://explorer.solana.com/tx/56JcSVYUPr8hdg8q2bfDhiPm5W9XQtr45VEevK9ye6Ec7DcyvD9CvnDgUoQhL3eQEmz32RRtLcaRdU9xyaDyCLiT?cluster=devnet
Before:
After:
