Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : improve clarity of yarn parallel scripts #55

Merged

Conversation

godhyzzang
Copy link
Collaborator

📄 Description of the PR

🔧 What has been changed?

I initially used the ‘&’ shell command to run parallel scripts, and it worked. However, to make it easier for others, I replaced the shell command with the yarn workspaces command.

This should now be clearer and easier to understand.

📸 Screenshots / GIFs (if applicable)

image

⚠️ Precaution & Known Issues

✅ Checklist

  • Confirm with the UI branch to ensure there are no visual issues.
  • Verify if function and variable names are descriptive enough to understand their purpose (ensure declarative code).

@godhyzzang godhyzzang requested a review from smosco January 5, 2025 12:58
@godhyzzang godhyzzang self-assigned this Jan 5, 2025
@godhyzzang godhyzzang linked an issue Jan 5, 2025 that may be closed by this pull request
3 tasks
Copy link

vercel bot commented Jan 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-player-plugin-prompter-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2025 1:51pm

Copy link
Owner

@smosco smosco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way makes it much clearer and less confusing.

@godhyzzang godhyzzang merged commit 968cb31 into develop Jan 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chore] Improve clarity of yarn parallel scripts
2 participants