Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : ignore dist in Git #49

Merged
merged 2 commits into from
Dec 17, 2024
Merged

fix : ignore dist in Git #49

merged 2 commits into from
Dec 17, 2024

Conversation

smosco
Copy link
Owner

@smosco smosco commented Dec 17, 2024

📄 Description of the PR

🔧 What has been changed?

  • Ignore core/dist in Git, but include it in the NPM package

📸 Screenshots / GIFs (if applicable)

⚠️ Precaution & Known Issues

✅ Checklist

  • Confirm with the UI branch to ensure there are no visual issues.
  • Verify if function and variable names are descriptive enough to understand their purpose (ensure declarative code).

@smosco smosco added the fix label Dec 17, 2024
@smosco smosco requested a review from godhyzzang December 17, 2024 09:24
@smosco smosco self-assigned this Dec 17, 2024
@smosco smosco linked an issue Dec 17, 2024 that may be closed by this pull request
[fix] hide dist #48
Closed
3 tasks
@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-player-plugin-prompter-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 9:24am

godhyzzang
godhyzzang approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@godhyzzang godhyzzang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, our github actions didn't have a 'build' command! Now I see.

@smosco smosco merged commit 9d89bdd into develop Dec 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godhyzzang godhyzzang godhyzzang approved these changes

Assignees

@smosco smosco

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] hide dist
2 participants
@smosco @godhyzzang