Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right-pad workflow name if it is too short #15881

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

vreff
Copy link
Contributor

@vreff vreff commented Jan 9, 2025

Workflow names are in some cases passed to the encoder as containing 7 bytes rather than 10, they must be right-padded with zero bytes up to the required length.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@vreff vreff marked this pull request as ready for review January 9, 2025 15:21
@vreff vreff requested review from a team as code owners January 9, 2025 15:21
@vreff vreff requested a review from patrickhuie19 January 9, 2025 15:21
Copy link
Contributor

github-actions bot commented Jan 9, 2025

AER Report: CI Core ran successfully ✅

aer_workflow , commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant