core: randomize p2p ports; consolidate GetFreePort implementations #10884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
I see that you haven't updated any README files. Would it make sense to do so? |
jmank88
force-pushed
the
randomize-ports
branch
from
6ebe676 to
dcc06f2
Compare
|
SonarQube Quality Gate
|
bolekk
approved these changes
Oct 9, 2023
| // GetFreePort returns a free port. | ||
| // NOTE: This approach is technically incorrect because the returned port | ||
| // can still be taken by the time the caller attempts to bind to it. | ||
| // Unfortunately, we can't specify zero port in P2P.V2.ListenAddresses at the moment. |
There was a problem hiding this comment.
FYI I asked Research about this here: https://chainlink-core.slack.com/archives/C042C3WPDNH/p1691442588046129
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
makramkd
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should reduce occurrences of
bind: address already in uselike: