Remove old Solidity code & move misplaced files (#15852)

* rm dead code

* move ChainSpecificUtil_v0_8_6.sol to vrf

* remove flags

* move chainlink client to operatorforwarder

* move automation test wrappers to automation

* more automation cleanup

* move interfaces to operatorforwarder

* remove TypeAndVersionInterface.sol in favor of ITypeAndVersion

* move and remove mocks

* move ChainSpecificUtil to shared

* move more testhelpers

* move MockV3Aggregator

* move logpoller related contracts to shared

* clean up broken references

* fix broken ref

* rebase

* fix lint & compile feeds

* gen wrapper for ITypeAndVersion

* fix lint

.changeset/cold-coats-battle.md

@@ -0,0 +1,5 @@
+---
+"chainlink": patch
+---
+
+#internal minor rename of various gethwrappers

.github/CODEOWNERS

@@ -89,14 +89,11 @@ core/scripts/gateway @smartcontractkit/dev-services
 /contracts/src/v0.8/automation @smartcontractkit/dev-services
 /contracts/src/v0.8/ccip @smartcontractkit/ccip-onchain
 /contracts/src/v0.8/functions @smartcontractkit/dev-services
-# TODO: interfaces folder, folder should be removed and files moved to the correct folders
 /contracts/src/v0.8/l2ep @smartcontractkit/bix-build
 /contracts/src/v0.8/llo-feeds @smartcontractkit/data-streams-engineers
 # TODO: mocks folder, folder should be removed and files moved to the correct folders
 /contracts/src/v0.8/operatorforwarder @smartcontractkit/data-feeds-engineers
 /contracts/src/v0.8/shared @smartcontractkit/core-solidity
-# TODO: tests folder, folder should be removed and files moved to the correct folders
-# TODO: transmission folder, owner should be found
 /contracts/src/v0.8/vrf @smartcontractkit/dev-services
 /contracts/src/v0.8/keystone @smartcontractkit/keystone
 /contracts/src/v0.8/workflow @smartcontractkit/dev-services

.github/workflows/solidity-foundry-artifacts.yml

@@ -69,7 +69,6 @@ jobs:
               - '!contracts/src/v0.8/**/*.t.sol'
               - '!contracts/src/v0.8/*.t.sol'
               - '!contracts/src/v0.8/**/testhelpers/**'
-              - '!contracts/src/v0.8/testhelpers/**'
               - '!contracts/src/v0.8/vendor/**'
             other_shared:
               - modified|added: 'contracts/src/v0.8/(interfaces/**/*.sol|*.sol)'

contracts/.changeset/angry-needles-approve.md

@@ -0,0 +1,5 @@
+---
+'@chainlink/contracts': minor
+---
+
+#internal Removal and moving of various older Solidity contracts. Unused test helpers are removed, used files are now in their proper product folders

contracts/STYLE_GUIDE.md

@@ -265,9 +265,6 @@ All contracts will expose a `typeAndVersion` constant.
 The string has the following format: `<contract name><SPACE><semver>-<dev>` with the `-dev` part only being applicable to contracts that have not been fully released.
 Try to fit it into 32 bytes to keep the impact on contract sizes minimal.
 
-Note that `ITypeAndVersion` should be used, not `TypeAndVersionInterface`.
-
-
 
 
 

contracts/scripts/lcov_prune

@@ -27,8 +27,6 @@ exclusion_list_ccip=(
   "src/v0.8/ccip/libraries/USDPriceWith18Decimals.sol"
   "src/v0.8/ccip/libraries/MerkleMultiProof.sol"
   "src/v0.8/ccip/libraries/Pool.sol"
-  "src/v0.8/ConfirmedOwnerWithProposal.sol"
-  "src/v0.8/tests/MockV3Aggregator.sol"
   "src/v0.8/ccip/applications/CCIPClientExample.sol"
   "src/v0.8/keystone/*"
 )

contracts/scripts/native_solc_compile_all

@@ -12,7 +12,7 @@ python3 -m pip install --require-hashes -r $SCRIPTPATH/requirements.txt
 # 6 and 7 are legacy contracts, for each other product we have a native_solc_compile_all_$product script
 # These scripts can be run individually, or all together with this script.
 # To add new CL products, simply write a native_solc_compile_all_$product script and add it to the list below.
-for product in automation events_mock feeds functions keystone llo-feeds logpoller operatorforwarder shared vrf ccip liquiditymanager workflow 
+for product in automation events_mock feeds functions keystone llo-feeds operatorforwarder shared vrf ccip liquiditymanager workflow
 do
   $SCRIPTPATH/native_solc_compile_all_$product
 done

contracts/scripts/native_solc_compile_all_automation

@@ -73,11 +73,11 @@ compileContract automation/testhelpers/UpkeepCounter.sol
 
 compileContract automation/interfaces/StreamsLookupCompatibleInterface.sol
 
-compileContract tests/VerifiableLoadUpkeep.sol
-compileContract tests/VerifiableLoadStreamsLookupUpkeep.sol
-compileContract tests/VerifiableLoadLogTriggerUpkeep.sol
-compileContract tests/AutomationConsumerBenchmark.sol
-compileContract tests/StreamsLookupUpkeep.sol
+compileContract automation/testhelpers/VerifiableLoadUpkeep.sol
+compileContract automation/testhelpers/VerifiableLoadStreamsLookupUpkeep.sol
+compileContract automation/testhelpers/VerifiableLoadLogTriggerUpkeep.sol
+compileContract automation/testhelpers/AutomationConsumerBenchmark.sol
+compileContract automation/testhelpers/StreamsLookupUpkeep.sol
 
 SOLC_VERSION="0.8.19"
 

contracts/scripts/native_solc_compile_all_feeds

@@ -30,5 +30,5 @@ compileContract () {
 }
 
 # Aggregators
-compileContract Chainlink.sol
-compileContract ChainlinkClient.sol
+compileContract operatorforwarder/Chainlink.sol
+compileContract operatorforwarder/ChainlinkClient.sol

contracts/scripts/native_solc_compile_all_shared

@@ -33,13 +33,16 @@ compileContract() {
   $command
 }
 
+compileContract interfaces/AggregatorV3Interface
+compileContract interfaces/ITypeAndVersion
 compileContract token/ERC677/BurnMintERC677
 compileContract token/ERC677/LinkToken
 compileContract token/ERC20/BurnMintERC20
 compileContract test/helpers/ChainReaderTester
+compileContract test/helpers/LogEmitter
+compileContract test/helpers/VRFLogEmitter
+compileContract mocks/MockV3Aggregator
 compileContract mocks/WERC20Mock
-compileContract interfaces/AggregatorV3Interface
 
 compileContract openzeppelin-solidity/v4.8.3/contracts/token/ERC20/ERC20 vendor
 compileContract multicall/ebd8b64/src/Multicall3 vendor
-compileContract MockV3Aggregator tests