Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NONEVM-1091] - Refactor/Setup CR init and cfg and codec init #991

Merged
merged 11 commits into from
Dec 30, 2024
Merged

[NONEVM-1091] - Refactor/Setup CR init and cfg and codec init #991

merged 11 commits into from
Dec 30, 2024

Conversation

ilija42
Copy link
Contributor

@ilija42 ilija42 commented Dec 23, 2024 •
edited
Loading

Description

  1. Refactor CR init and codec init to be more like EVM CR
  2. CR now discerns codec input and output modifiers
  3. Rewrite cfg to match the new development
  4. Rewrite cfg validation and unmarshal to allow IDL to be passed in both as a string or structured
  5. Align naming for all type naming vars for CR to be genericName<>chainSpecificName

@ilija42 ilija42 requested a review from a team as a code owner December 23, 2024 18:46
@ilija42 ilija42 marked this pull request as draft December 23, 2024 18:47
@ilija42 ilija42 force-pushed the NONEVM-702-cleanup-codec-usage branch from 9c4e95d to 382f401 Compare December 24, 2024 11:58
@ilija42 ilija42 requested a review from silaslenihan December 24, 2024 21:37
@ilija42 ilija42 changed the title Refactor/Setup CR init and cfg and codec init [NONEVM-1060] - Refactor/Setup CR init and cfg and codec init Dec 24, 2024
@ilija42 ilija42 changed the title [NONEVM-1060] - Refactor/Setup CR init and cfg and codec init [NONEVM-1091] - Refactor/Setup CR init and cfg and codec init Dec 24, 2024
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
74.3% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

silaslenihan
silaslenihan approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@silaslenihan silaslenihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jadepark-dev jadepark-dev merged commit 4d88833 into develop Dec 30, 2024
35 of 36 checks passed
@jadepark-dev jadepark-dev deleted the NONEVM-702-cleanup-codec-usage branch December 30, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silaslenihan silaslenihan silaslenihan approved these changes

@jadepark-dev jadepark-dev jadepark-dev approved these changes

@EasterTheBunny EasterTheBunny Awaiting requested review from EasterTheBunny

@toblich toblich Awaiting requested review from toblich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ilija42 @EasterTheBunny @jadepark-dev @silaslenihan