Add discriminator to the account and allow encoding/decoding of non-account types #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolag
force-pushed
the
rtinianov_lenient
branch
from
fe9bc90 to
9a44563
Compare
nolag
force-pushed
the
rtinianov_lenient
branch
from
9a44563 to
fc974f2
Compare
nolag
force-pushed
the
rtinianov_discriminator
branch
from
13cfae3 to
0f5ebb4
Compare
nolag
force-pushed
the
rtinianov_discriminator
branch
from
0f5ebb4 to
ea5f04f
Compare
nolag
force-pushed
the
rtinianov_discriminator
branch
from
ea5f04f to
4585c2f
Compare
jmank88
reviewed
Apr 24, 2024
aalu1418
reviewed
Apr 24, 2024
| if includeDiscriminator { | ||
| desLen = 1 | ||
| } | ||
| named := make([]encodings.NamedTypeCodec, len(*def.Type.Fields)+desLen) |
There was a problem hiding this comment.
is there a nil pointer concern for dereferencing?
There was a problem hiding this comment.
I didn't add it in this PR, but I don't think so. The call only gets made if the type is a struct so I expect the fields would be present but empty if there are no fields.
There are a few derefs later on as well.
aalu1418
previously approved these changes
Apr 24, 2024
jmank88
reviewed
Apr 25, 2024
nolag
force-pushed
the
rtinianov_discriminator
branch
from
4585c2f to
d6720af
Compare
jmank88
approved these changes
Apr 25, 2024
nolag
force-pushed
the
rtinianov_discriminator
branch
from
d6720af to
558dbd8
Compare
aalu1418
approved these changes
Apr 25, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an account is stored from an Anchor contract on Solana, a discriminator is added as the first 8 bytes to ensure that the right data is being loaded. This was missed when decoding the account.
Additionally, users can define types and should be able to encode them to either sign or write to chain. This PR adds that ability as well.