Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release process #2852

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

ozangunalp
Copy link
Collaborator

No description provided.

Copy link
Contributor

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @jponge can you have a quick look?

@ozangunalp
Copy link
Collaborator Author

Btw it is normal that the review release is failing, it doesn't have permission to add review to a PR coming from a fork.

@cescoffier
Copy link
Contributor

Yes, you need to push the branch to the main repo and not your fork.

@jponge
Copy link
Member

jponge commented Dec 13, 2024

I've moved the Mutiny workflow to be local-centric with a justfile, and only have actions to push tags to Maven Central, and rebuild the website. I was having too many issues in running the whole workflow in CI, especially with JReleaser not getting the correct commit range.

I have had 0 issue on Mutiny Zero / Vert.x bindings with the standard SmallRye release process, so your mileage varies :-)

@jponge
Copy link
Member

jponge commented Dec 13, 2024

(I was too quick to send)

The standard workflow is fine, but if it doesn't work and you don't want to spend hours debugging GItHub Actions failures, local steps work quite well.

@ozangunalp
Copy link
Collaborator Author

I didn't want to diverge from the Smallrye release process so I removed the release notes generation via JReleaser.

@ozangunalp ozangunalp merged commit 1310355 into smallrye:main Dec 16, 2024
5 of 6 checks passed
@ozangunalp ozangunalp added this to the 4.26.0-RC1 milestone Dec 16, 2024
@ozangunalp ozangunalp deleted the new_release_process branch December 16, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants