Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for dbt 1.7 #72

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Conversation

pgoslatara
Copy link
Contributor

This PR adds support for dbt 1.7. Only point of difference from 1.6 is the introduction of a change to dbt clean in #8469 which prevents dbt clean from deleting directories outside the current project scope. To work around this, the environment variable DBT_CLEAN_PROJECT_FILES_ONLY is Monkeypatched.

Additionally, .gitignore is added so that tox can be run locally without adding new files to any commits.

@sweco sweco self-requested a review February 19, 2024 21:30
Copy link
Collaborator

@sweco sweco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pgoslatara, many thanks for the PR. 😊 Looks all good, I just thought that it would be worth removing the monkey-patching if possible.

tox.ini Show resolved Hide resolved
tests/integration/test_init.py Outdated Show resolved Hide resolved
@sweco sweco merged commit e839c16 into slidoapp:main Feb 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants