Prevent white splash on cold start #868
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently gh4a sets the user theme in BaseActivity::onCreate() but still the white splash is frequently shown on budget devices during a cold start of the app, which is extremely annoying in case the dark theme is used in the app and in the entire UI of the device. This patch makes it so that a transparent default theme is shown before the actual theme is applied. On a slower device nothing will be shown after the user launched the app until the main screen is presented so one might think that could perplex some users, but I think they are used to their device being slow and encounter such pauses regularly. On a fast device there'll be no perceivable difference to the old behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently gh4a sets the user theme in BaseActivity::onCreate()
gh4a/app/src/main/java/com/gh4a/BaseActivity.java
Lines 138 to 139 in b07d0d4
This patch makes it so that a transparent default theme is shown before the actual theme is applied. On a slower device nothing will be shown after the user launched the app until the main screen is presented so one might think that could perplex some users, but I think they are used to their device being slow and encounter such pauses regularly. On a fast device there'll be no perceivable difference to the old behavior.