Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Cmake minimum version to allow using CMAKE_MSVC_RUNTIME_LIBRARY flag #509

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Increase Cmake minimum version to allow using CMAKE_MSVC_RUNTIME_LIBRARY flag #509

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.12)
cmake_minimum_required(VERSION 3.15)
project(re2c VERSION 4.0 HOMEPAGE_URL "https://re2c.org/")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you use CMAKE_MSVC_RUNTIME_LIBRARY? I'm not against increasing, but it's strange to increase it for something that is not used anywhere in the build files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be needed for this issue: Pre-built release binaries? #379
Currently it is used in my repo that produces a Windows binary: re2c-for-Windows/build.ps1


list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")
Expand Down
Loading