Fixes #1669: restore router memory statistics #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -744,13 +744,14 @@ class BusManager: | |||
|
|
|||
| # attempt to get the qdrouterd process memory usage | |||
| # this may not be present on all platforms | |||
| router = self.query('io.skupper.router.router')[0] | |||
| router_metrics = self.query('io.skupper.router.routerMetrics')[0] | |||
There was a problem hiding this comment.
Darn ! It looks like I introduced this bug !! Sorry, thanks for fixing it
There was a problem hiding this comment.
np - the real bug was in the CI test I wrote that didn't verify these metrics were present. Had I done that correctly we would've caught this in development.
ganeshmurthy
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.