chore: remove provider reference from task struct #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadim-az
requested review from
Zygimantass,
aljo242 and
Eric-Warehime
as code owners
nadim-az
force-pushed
the
na/remove-provider-reference
branch
from
d5e97e4 to
2693b99
Compare
nadim-az
commented
Jan 17, 2025
| @@ -178,7 +168,7 @@ func (t *Task) GetStatus(ctx context.Context) (provider.TaskStatus, error) { | |||
| case "paused": | |||
| return provider.TASK_PAUSED, nil | |||
| case "restarting": | |||
| return provider.TASK_RUNNING, nil // todo(zygimantass): is this sane? | |||
| return provider.TASK_RESTARTING, nil | |||
There was a problem hiding this comment.
@Zygimantass flagging this change, lmk if you see any issues with this distinction
nadim-az
force-pushed
the
na/remove-provider-reference
branch
from
dc0b2dc to
5626cde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.