Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abhishek feature branch #171

Conversation

abhishekshivgan
Copy link

@abhishekshivgan abhishekshivgan commented Sep 3, 2024

Bugs:

  1. Footer content was not visible because of the Plus Icon. Plus icon in footer needs to align properly it is hiding footer content  #69
  2. Just to view the Blogs, user has to login. This is not ideal for any user. It highly increases the bounce rate of the site.

Type of change

  • I have aligned all the elements in center so that it is visible and looks beautiful. Now the footer is completely visible
  • I have shifted blog routes from protected route to public route. This way, if a user visits a blog, he will be able to read the blog. This will decrease the bounce rate. The inspiration for this feature is Medium Blogging Site.

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project

  • I have performed a self-review of my own code

  • New and existing unit tests pass locally with my changes

  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable):

myblog

Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for tech-stuffs ready!

Name Link
🔨 Latest commit 62263a8
🔍 Latest deploy log https://app.netlify.com/sites/tech-stuffs/deploys/66d6eeb2a933930008406748
😎 Deploy Preview https://deploy-preview-171--tech-stuffs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Sep 3, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@singhJasvinder101
Copy link
Owner

singhJasvinder101 commented Sep 3, 2024

Great work @abhishekshivgan but speeddial is still hiding the footer content
https://deploy-preview-171--tech-stuffs.netlify.app/

also you can fix the white space above the footer issue for lower screens

@abhishekshivgan
Copy link
Author

Great work @abhishekshivgan but speeddial is still hiding the footer content https://deploy-preview-171--tech-stuffs.netlify.app/

also you can fix the white space above the footer issue for lower screens

Can you provide some more insights on this speeddial component. I am not getting what you are referring to. A screenshot would be nice.

I will also look at the white space in footer

@singhJasvinder101
Copy link
Owner

For lower screens

image

@abhishekshivgan
Copy link
Author

@singhJasvinder101 got it. where exactly do you prefer to align the speeddial component?

@singhJasvinder101
Copy link
Owner

singhJasvinder101 commented Sep 4, 2024

little bottom margin will be fine I think. Main thing is It must not hide footer content for lower screens

@singhJasvinder101
Copy link
Owner

are you working on this issue ?

@singhJasvinder101 singhJasvinder101 merged commit 8490c3e into singhJasvinder101:main Oct 1, 2024
6 of 7 checks passed
Copy link

github-actions bot commented Oct 1, 2024

Thank you @abhishekshivgan, for your valuable time and contribution to our TechBytes! 💗

It’s our TechBytes, so let’s build this TechBytes together!! 🤝

Hoping to see more of your contributions soon. 😇

Wishing you all the best on your journey into Open Source! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants