Improved callback support added Task support and passing SessionRecord #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Won't this deadlock if you call decrypt on a task with a synchronization context? Do we need asynchronity here so far down in the signal stack? |
Improved callback support added Task support and passing SessionRecord This modifies the existing callback support to work with Task based callbacks. It also passes the session version (when available) to the callback (as not yet committed for prekey), needed for protocol version check code that already exists.
mitchcapper
force-pushed
the
callback_support_improvements_pr
branch
from
87c1b1f to
5f21f6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for signal-csharp/libsignal-service-dotnet#34