fix: generate UKI only if actually needed #10151
Merged
+33
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
approved these changes
Jan 16, 2025
smira
force-pushed
the
fix/imager-uki-gen
branch
from
6509232 to
c201476
Compare
smira
force-pushed
the
fix/imager-uki-gen
branch
from
c201476 to
fe46838
Compare
Without this fix, imager tries to generate UKI when it's not needed at all, and also it might try to generate UKI when it's not even supported for the version of Talos. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
force-pushed
the
fix/imager-uki-gen
branch
from
fe46838 to
4310b29
Compare
DmitriyMV
approved these changes
Jan 16, 2025
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix, imager tries to generate UKI when it's not needed at all, and also it might try to generate UKI when it's not even supported for the version of Talos.