SG_ADD refactor #8
Conversation
|
let's do it :) |
| SG_ADD(&m_max_iter, "m_max_iter", "max number of iterations",MS_NOT_AVAILABLE); | ||
| SG_ADD(&m_z, "m_z", "regularization constant", ParameterProperties::HYPER); | ||
| SG_ADD(&m_epsilon, "m_epsilon", "tolerance epsilon"); | ||
| SG_ADD(&m_max_iter, "m_max_iter", "max number of iterations"); |
There was a problem hiding this comment.
we should introduce an attribute for parameters like this one .... these are hyper-parameters, but not in the classical sense (as in that we want to tune them). But still free parameters ...
@vigsterkr @lisitsyn ?
|
ah nevermind |
|
once this submodule update is merged, you will need to update the submodule commit hash in the main develop repo, so that it is included in the develop branch |
|
Minor: it would be good to write more meaningful commit messages so that we can later easily see what has happened |
OK, I will start a PR with that.
OK! I can write something with more information with a reference to the PR to shogun. I can write that in the PR message? |
|
|
How can I edit the message of the existing commit? Just did How can I push to here? |
|
Yes that’s it |
|
So do I start a new PR with the amended commit message? |
|
Nono just amend and force push. Your pr will be overwritten/updated |
I applied the same refactoring to SG_ADD as in here.