Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for PHP 8.2 #67

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Drop support for PHP 8.2 #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com), and this
* *Nothing*

### Removed
* *Nothing*
* Drop support for PHP 8.2

### Fixed
* *Nothing*
Expand Down
10 changes: 5 additions & 5 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,21 +12,21 @@
}
],
"require": {
"php": "^8.2",
"php": "^8.3",
"league/event": "^3.0",
"psr/event-dispatcher": "^1.0",
"psr/log": "^3.0",
"shlinkio/shlink-config": "^3.3",
"shlinkio/shlink-config": "^3.4",
"shlinkio/shlink-json": "^1.2"
},
"require-dev": {
"phpstan/phpstan": "^2.0",
"phpstan/phpstan": "^2.1",
"phpstan/phpstan-phpunit": "^2.0",
"phpunit/phpunit": "^11.4",
"phpunit/phpunit": "^11.5",
"roave/security-advisories": "dev-master",
"shlinkio/php-coding-standard": "~2.4.0",
"spiral/roadrunner-jobs": "^4.6",
"symfony/var-dumper": "^7.1"
"symfony/var-dumper": "^7.2"
},
"suggest": {
"spiral/roadrunner-jobs": "To be able to run async event dispatchers as roadrunner job tasks"
Expand Down
2 changes: 1 addition & 1 deletion src/RoadRunner/RoadRunnerEventDispatcherFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

class RoadRunnerEventDispatcherFactory
{
public const ROAD_RUNNER_DISPATCHER = __NAMESPACE__ . '\RoadRunnerEventDispatcher';
public const string ROAD_RUNNER_DISPATCHER = __NAMESPACE__ . '\RoadRunnerEventDispatcher';

public function __invoke(ContainerInterface $container): EventDispatcher
{
Expand Down
2 changes: 1 addition & 1 deletion test/RoadRunner/RoadRunnerEventDispatcherFactoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,10 @@ private function container(
];
$hasServiceReturnMap = [
[RequestIdProviderInterface::class, $hasRequestIdProvider],
[EnabledListenerCheckerInterface::class, $listenerChecker !== null],
];

if ($listenerChecker !== null) {
$hasServiceReturnMap[] = [EnabledListenerCheckerInterface::class, true];
$getServiceReturnMap[] = [EnabledListenerCheckerInterface::class, $listenerChecker];
}

Expand Down